Repository navigation
Explain why upload type recovery must be retained - #7245
Draft
shreyas-goenka wants to merge 2 commits into
Draft
shreyas-goenka wants to merge 2 commits into
shreyas-goenka wants to merge 2 commits into
Conversation
Collaborator
Integration test reportCommit: b5781d1
Top 6 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the CLI v1.21/v1.22 regression from #6149 and #7034, the different notebook detection rules used by the upload paths, and why reverting to
import-filein #7218 needs delete-and-retry recovery for existing deployments. Include the UTF-8 BOM example and explain that this compatibility code can be removed once the risk from direct upgrades from those versions is negligible.Only a code comment changes. Validation:
git diff --check.