Skip to content

fix(learning): repair MODEL_ENDPOINT 400 + bump engine to 654a31d0 - #905

Merged
eric-wang-1990 merged 1 commit into
mainfrom
ai/bump-engine-654a31d0
Aug 13, 2026
Merged

fix(learning): repair MODEL_ENDPOINT 400 + bump engine to 654a31d0#905
eric-wang-1990 merged 1 commit into
mainfrom
ai/bump-engine-654a31d0

Conversation

@eric-wang-1990

@eric-wang-1990 eric-wang-1990 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What

Two changes to the engineer-bot learning flow:

  1. Fix the daily-failing cron (MODEL_ENDPOINT). The learning workflow used .../serving-endpoints/anthropic/invocations, which is not translated correctly: sdk_agent.translate_endpoint early-returns on URLs already containing /serving-endpoints/anthropic, keeping the trailing /invocations. The CLI then appends /v1/messages.../serving-endpoints/anthropic/invocations/v1/messages400 Unsupported native API path. This repo's learning cron has failed every scheduled run with exactly this error (e.g. run 31624062797). Switch to the concrete .../serving-endpoints/databricks-claude-opus-4-8/invocations form that reviewer-bot.yml / engineer-bot.yml use successfully.

  2. Bump the engine pin d05dcb11654a31d0 (engine main, 30 commits): brings per-bot model selection. SDK/CLI (0.2.102 / 2.1.61) unchanged at that SHA — SHA-only.

Why together

The endpoint bug is why the retrospective never actually ran here despite the flow being wired up. Fixing it + bumping to the current engine gets the daily learning extraction working on main for the first time. The same endpoint fix is going out to the sibling driver repos' learning PRs.

Note

The effective model is engine-owned (repo_conventions.engineer_bot_model() = databricks-claude-opus-4-8[1m], override via ENGINEER_BOT_MODEL_OVERRIDE); the model segment in the URL is discarded by translate_endpoint, so this is purely a routing/base-URL fix.

This pull request and its description were written by Isaac.

Move all bots to engine main (654a31d0), 30 commits ahead of the current pin.
This repo already runs the modern daily-cron retrospective + closed loop; this
brings the pinned engine in line with the sibling driver repos (kernel + the
go/nodejs/jdbc/odbc learning PRs), whose engine was bumped to the same SHA.

The main addition since d05dcb11 is per-bot model selection (default opus-4.8).
SDK/CLI locked versions (0.2.102 / 2.1.61) are unchanged at 654a31d0, so this is
a SHA-only bump — no install-bot-engine edit needed.

Co-authored-by: Isaac
Signed-off-by: eric-wang-1990 <e.wang@databricks.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pinned bot engine commit used by the shared .github/actions/bot-prelude composite action, aligning this repo’s bot workflows with the newer engine SHA referenced by sibling repositories.

Changes:

  • Bump the engine-ref input default from d05dcb11… to 654a31d0… in the bot prelude composite action.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

@eric-wang-1990
eric-wang-1990 merged commit b367a62 into main Aug 13, 2026
49 of 50 checks passed
@eric-wang-1990 eric-wang-1990 changed the title chore(bots): bump engine pin to 654a31d0 (per-bot models) fix(learning): repair MODEL_ENDPOINT 400 + bump engine to 654a31d0 Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants