claude: honor $CLAUDE_CONFIG_DIR for the settings file location

[eabrouwer3]

Claude Code reads its user config from $CLAUDE_CONFIG_DIR when set, but ucode hardcoded ~/.claude. Users who keep separate personal and work config dirs got a ucode-settings.json written somewhere the launched claude never reads.

Add a claude_config_dir() helper that resolves the env var with a fallback to ~/.claude, so existing setups are unchanged.

Fixes #342

[Copilot]

Pull request overview

This PR updates the Claude Code agent integration so ucode writes/reads its Claude settings file from the same config directory Claude Code uses: $CLAUDE_CONFIG_DIR when set, otherwise ~/.claude. This resolves cases where users switch between multiple Claude config directories and ucode previously wrote ucode-settings.json into the wrong location.

Changes:

• Add a claude_config_dir() helper to resolve $CLAUDE_CONFIG_DIR with a ~/.claude fallback (including tilde expansion and blank-var fallback).
• Update the Claude agent to compute its settings path from claude_config_dir().
• Add unit tests covering default behavior, env-var overrides, tilde expansion, and blank env-var fallback.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/ucode/config_io.py	Adds claude_config_dir() helper for resolving the Claude Code config directory from environment with backward-compatible fallback.
src/ucode/agents/claude.py	Switches Claude settings directory to be derived from claude_config_dir() instead of a hardcoded ~/.claude.
tests/test_config_io.py	Adds focused tests validating claude_config_dir() behavior across env/default cases.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/ucode/agents/claude.py:2

• The module docstring says it writes the settings.json env block, but this agent actually writes ucode-settings.json (a settings.json-format overlay). Clarifying the filename here will reduce confusion now that the config directory is no longer always ~/.claude.

"""Claude Code agent: writes the settings.json env block into Claude Code's config
directory (``~/.claude`` by default, or ``$CLAUDE_CONFIG_DIR`` when set)."""

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/ucode/managed_resolve.py:10

• This docstring example mixes the default path (~/.claude/ucode-settings.json) with the env-var override in a way that's easy to misread as both applying simultaneously. Consider describing the location as "/ucode-settings.json" with the default and $CLAUDE_CONFIG_DIR fallback spelled out once.

(e.g. ``~/.claude/ucode-settings.json``, under ``$CLAUDE_CONFIG_DIR`` when that is set), so managed
settings take precedence for every ``ucode`` command without either file being rewritten.

src/ucode/agents/claude.py:2

• Module docstring says the agent writes a "settings.json" env block, but this module actually writes ucode's overlay file ucode-settings.json (see CLAUDE_SETTINGS_PATH). Updating the docstring avoids confusion about which file ucode manages.

"""Claude Code agent: writes the settings.json env block into Claude Code's config
directory (``~/.claude`` by default, or ``$CLAUDE_CONFIG_DIR`` when set)."""