Repository navigation
Conversation
…tion journeys Copilot's shell tool tries pwsh first; with only Windows PowerShell on the test PATH its 40s startup probe can time out, leaving Copilot without a shell, so the revoke/sign-out step never runs. Expose pwsh to Copilot lanes on Windows. gpt-5-4-nano sometimes drops the path segment after the space in 'project with spaces' when it rebuilds the file's absolute path. Give the GPT journeys the full path. Co-authored-by: Isaac <no-reply@databricks.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| # startup probe on a cold runner and leave Copilot without a shell. | ||
| pwsh = shutil.which("pwsh", path=base_env.get("PATH")) | ||
| if "copilot" in agents and pwsh: | ||
| runtime_paths.append(Path(pwsh).parent) |
Contributor
There was a problem hiding this comment.
what happens if pwsh lives in a shared dir like %LOCALAPPDATA%\Microsoft\WindowsApps (Store install)? that puts every alias there on PATH, which breaks the isolation the tool_bin comment above relies on. can we link pwsh into tool_bin instead?
Collaborator
Author
|
Closing: folding these fixes into #1218 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
What did you change, and why?
Two Copilot integration journeys fail intermittently because of their environment, not ug:
pwsh.exefirst, but the runner's restricted test PATH only has Windows PowerShell, whose startup probe sometimes exceeds Copilot's 40s limit (PowerShell is not available ... Command timed out after 40000ms). The step then never runs and the journey fails with "Copilot never ran the revoke step".scripts/run_integration.pynow adds the directory ofpwshto the PATH for Copilot lanes on Windows, when the runner has it.project with spaces.gpt-5-4-nanosometimes rebuilds the file's absolute path without the part after the space (.../project/input-....txt) and gives up.FileTask.prompt_with_pathgives the full path, and the Copilot GPT journeys (headless GPT, configure/repeat/revert, upgrade) use it.No product code changes.
How is this tested?
tests/test_integration_runner.py,tests/test_integration_evidence.pyandtests/test_integration_contract.pypass, and lint is clean.This pull request and its description were written by Isaac.