feat(plugins): ship Agent Plugins v1.0.0 portable package by crmapj · Pull Request #91 · dataiku/dataiku-headless

crmapj · 2026-08-06T18:37:14Z

Summary

Adds portable Agent Plugins v1.0.0 packaging so any conforming client can load this repo as a plugin without harness-specific manifests.

Portable floor: root plugin.json + root mcp.json (stdio dataiku → sh ${PLUGIN_ROOT}/bin/launcher.sh) + existing skills/
Additive migration: keep .claude-plugin/, .codex-plugin/, and .mcp.json as parallel legacy packaging (not reverse-domain Agent Plugins extensions)
Launcher: prefer standard PLUGIN_ROOT / PLUGIN_DATA, fall back to Claude vars, then local checkout .deps/
Release lockstep: include portable plugin.json in Commitizen version_files (version-key selector so schema 1.0.0 URLs are not rewritten) and bump.yml verification
Release atomicity: bump with push: false, verify manifests + $schema URLs, then push commit/tags

How we ship plugins today vs after this PR

Surface	Before	After
Claude Code	`.claude-plugin/`	unchanged + portable core available
Codex	`.codex-plugin/`	unchanged + portable core available
Contributor dogfood	`.mcp.json`	unchanged
Agent Plugins clients	n/a	root `plugin.json` + `mcp.json` + `skills/`

Reviews

Adversarial review — GPT-5.6 Sol @ xhigh (cbrain job `414bbe8c-…`)

Verdict on first pass: REQUEST CHANGES. Findings addressed in the follow-up commit:

Severity	Finding	Resolution
Blocker	`tomllib` import breaks Python 3.10 CI collection	Use `importlib.metadata.version` instead
High	Manifest verify ran after remote push/tag	`push: false` → verify → explicit push
Medium	Happy-path-only tests	Schema-selector sim, stricter cwd, local fallback, launcher path existence
Medium	AGENTS.md stale	Updated
Medium / residual	Credentials still under `~/.dataiku`, not `PLUGIN_DATA`	Accepted residual — changing config location is a separate behavior change; runtime/cache already use `PLUGIN_DATA`
Residual	Windows/`sh`	Documented POSIX assumption for portable MCP

Spec checklist from Sol: portable manifest, skills discovery, closed stdio MCP, placeholders, reserved env names, schema-version match — Pass. Release atomicity and partial PLUGIN_DATA state were the only fail/partial items; atomicity is fixed, credential path is deferred.

Thermo-nuclear code quality review

Bar	Result
File-size explosion (>1k)	No — only small packaging/docs/tests
Spaghetti / special-case growth in shared paths	No — launcher change is a clear precedence chain
Unnecessary abstraction	No — plain JSON + stdlib tests
Code-judo opportunity	Multi-harness MCP launch config remains duplicated by design (incompatible client schemas); consolidating would break Claude/Codex. Acceptable for additive migration.
Wrong-layer logic	No

Thermonuclear verdict: approve structure as-is for an additive packaging PR; no restructure required before merge.

Test plan

uv run pytest (161 passed)
uv run pytest tests/test_agent_plugins.py
sh -n bin/launcher.sh
uv run ruff check tests/test_agent_plugins.py
uv run cz check --rev-range origin/main..HEAD
CI green on this PR (3.10–3.14 matrix)
Optional: install via a harness that supports Agent Plugins and confirm skill + MCP load

Residual risks (not blocking)

Credential file location still prefers ~/.dataiku/config.json rather than ${PLUGIN_DATA}/config.json. Uninstall does not remove profiles. Follow-up if portable clients need sandboxed lifecycle-bound config.
Harness manifests remain non-portable (.claude-plugin/, etc.). Intentional parallel packaging until those clients load root Agent Plugins natively.
Portable stdio MCP assumes POSIX sh, matching existing Claude/Codex launchers.

Add root plugin.json and mcp.json so clients that implement the open Agent Plugins standard can discover skills and the stdio MCP server without harness-specific manifests. Keep Claude/Codex packages as additive compatibility layers, honor PLUGIN_ROOT/PLUGIN_DATA in the launcher, and lock the portable version into release bump verification.

Address Sol/xhigh adversarial findings: drop tomllib so 3.10 CI can collect tests, verify manifests before pushing release tags, lock schema URL rewrites, and cover version-selector + local-fallback cases.

CI pre-commit failed because ruff-format rewrote tests/test_agent_plugins.py.

nmartorell · 2026-08-07T15:27:24Z

+      "command": "sh",
+      "args": ["${PLUGIN_ROOT}/bin/launcher.sh"],
+      "env": {
+        "UV_CACHE_DIR": "${PLUGIN_DATA}/uv-cache"


@crmapj do we not need the env vars that are present in the Codex/Claude plugin jsons?

Checked - this isn't supported by the Agent Plugin standard atm.

nmartorell · 2026-08-07T15:28:08Z

@hanneshapke would you be able to review the changes to bump.yml, RELEASE.md and pyproject.toml?

Add root plugin.json and mcp.json so clients that implement the open Agent Plugins standard can discover skills and the stdio MCP server without harness-specific manifests. Keep Claude/Codex packages as additive compatibility layers, honor PLUGIN_ROOT/PLUGIN_DATA in the launcher, and lock the portable version into release bump verification.

Address Sol/xhigh adversarial findings: drop tomllib so 3.10 CI can collect tests, verify manifests before pushing release tags, lock schema URL rewrites, and cover version-selector + local-fallback cases.

CI pre-commit failed because ruff-format rewrote tests/test_agent_plugins.py.

…' into pr-91 # Conflicts: # AGENTS.md

…to pr-91 # Conflicts: # AGENTS.md # CODING_STANDARDS_AND_STRUCTURE.md # README.md # mcp.json # plugin.json # tests/test_agent_plugins.py

Kiro's IDE installs Agent Plugins v1.0.0 packages as powers, so make the repository root one: root plugin.json and mcp.json alongside the existing skills/. Kiro copies the whole package to ~/.kiro/powers/<name>/ minus .git, so ${PLUGIN_ROOT}/runtime/run_mcp.py resolves after install. ${PLUGIN_ROOT} is expanded in args and cwd but never in command, so the command stays a plain PATH lookup. Keep .kiro/settings/mcp.json for Kiro CLI, which has no power install and no skill loader: it reads the workspace MCP config and takes context from steering and AGENTS.md instead. Add the portable manifest to Commitizen version_files with a "version" key selector; the plain form rewrites the 1.0.0 schema URLs once [project].version reaches 1.0.0. Note: root plugin.json, mcp.json and tests/test_agent_plugins.py duplicate #91, which ships the same portable package. Whichever lands first makes the other a trivial resolution.

The Kiro IDE installs Agent Plugins v1.0.0 packages as powers, so make the repository root one: root plugin.json and mcp.json alongside the existing skills/. Kiro copies the whole package to ~/.kiro/powers/<name>/ minus .git, so ${PLUGIN_ROOT}/runtime/run_mcp.py resolves after install. ${PLUGIN_ROOT} is expanded in args and cwd but never in command, so the command stays a plain PATH lookup. Kiro CLI is out of scope: it has no power install and no skill loader. Add the portable manifest to Commitizen version_files with a "version" key selector; the plain form rewrites the 1.0.0 schema URLs once [project].version reaches 1.0.0. Note: root plugin.json, mcp.json and tests/test_agent_plugins.py duplicate #91, which ships the same portable package. Whichever lands first makes the other a trivial resolution.

Stacked on #91, which ships the portable Agent Plugins package. Kiro's IDE installs that package as a power, so this adds only what is Kiro-specific. - README: how to install the power, where Kiro puts it, and that Kiro CLI cannot install one. Record that Kiro passes only HOME, PATH, SHELL, TERM, USER and LOGNAME to an MCP subprocess, so shell exports of DKU_DSS_URL / DKU_API_KEY never reach the server and ~/.dataiku/config.json is the path that works. - plugin.json: add displayName so the Powers panel shows a real name, and narrow keywords to dataiku and cobuild — Kiro activates a power on keyword match, and mcp/agent are broad enough to trigger it on unrelated work. - Allow displayName in the manifest contract test; Kiro's loader accepts it.

crmapj added 2 commits August 6, 2026 18:08

fix(plugins): harden Agent Plugins packaging after review

ecaa9da

Address Sol/xhigh adversarial findings: drop tomllib so 3.10 CI can collect tests, verify manifests before pushing release tags, lock schema URL rewrites, and cover version-selector + local-fallback cases.

crmapj marked this pull request as ready for review August 6, 2026 18:40

crmapj added 2 commits August 6, 2026 19:08

style: ruff-format agent plugins tests

778554b

CI pre-commit failed because ruff-format rewrote tests/test_agent_plugins.py.

ci: re-trigger checks after ruff-format fix

1e27d17

nmartorell reviewed Aug 7, 2026

View reviewed changes

nmartorell requested a review from hanneshapke August 7, 2026 15:29

nmartorell force-pushed the agent/agent-plugins-standard branch from f4a79f1 to 1e27d17 Compare August 17, 2026 22:04

nmartorell mentioned this pull request Aug 17, 2026

refactor(codex): migrate native plugin to Agent Plugins #116

Draft

2 tasks

crmapj and others added 5 commits August 26, 2026 08:29

fix(plugins): harden Agent Plugins packaging after review

8326d43

Address Sol/xhigh adversarial findings: drop tomllib so 3.10 CI can collect tests, verify manifests before pushing release tags, lock schema URL rewrites, and cover version-selector + local-fallback cases.

style: ruff-format agent plugins tests

6607baf

CI pre-commit failed because ruff-format rewrote tests/test_agent_plugins.py.

ci: re-trigger checks after ruff-format fix

451ae1a

fix(plugins): keep portable MCP on direct uv launch

3e03ea8

JedIV mentioned this pull request Aug 26, 2026

feat(plugins): add agent-assisted setup #129

Merged

7 tasks

pmasiphelps added 7 commits September 10, 2026 08:12

fix(plugins): support Claude-hosted uploads

799b91b

Merge branch 'main' into pr-91

b3478c6

Merge remote-tracking branch 'origin/main' into pr-91

400fd66

Merge remote-tracking branch 'origin/fix/claude-hosted-runtime-layout…

31a1ad6

…' into pr-91 # Conflicts: # AGENTS.md

fix(plugins): update portable runtime launch

9a7fe8f

Merge remote-tracking branch 'origin/agent/agent-plugins-standard' in…

a9d1dea

…to pr-91 # Conflicts: # AGENTS.md # CODING_STANDARDS_AND_STRUCTURE.md # README.md # mcp.json # plugin.json # tests/test_agent_plugins.py

fix(tests): stabilize portable skill discovery

d1cb7e2

ludwigehlert-gif force-pushed the agent/agent-plugins-standard branch 2 times, most recently from c0e11c1 to d1cb7e2 Compare September 14, 2026 21:36

This was referenced Sep 18, 2026

feat(kiro): add Kiro MCP auto-discovery and skill install docs #67

Open

docs: add Privacy Policy link and support contact required for Kiro powers registry submission #158

Open

Navigation Menu

feat(plugins): ship Agent Plugins v1.0.0 portable package - #91

feat(plugins): ship Agent Plugins v1.0.0 portable package#91
crmapj wants to merge 16 commits into
mainfrom
agent/agent-plugins-standard

crmapj commented Aug 6, 2026

Uh oh!

nmartorell Aug 7, 2026

Uh oh!

nmartorell Aug 10, 2026

Uh oh!

nmartorell commented Aug 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

crmapj commented Aug 6, 2026

Summary

How we ship plugins today vs after this PR

Reviews

Adversarial review — GPT-5.6 Sol @ xhigh (cbrain job 414bbe8c-…)

Thermo-nuclear code quality review

Test plan

Residual risks (not blocking)

Uh oh!

nmartorell Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

nmartorell Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

nmartorell commented Aug 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Adversarial review — GPT-5.6 Sol @ xhigh (cbrain job `414bbe8c-…`)