Repository navigation
Drop /metadata download from dump API (moved to CKAN) - #36
Merged
Merged
Conversation
The resource + dataset metadata export is CKAN data, not datastore data, so
it moves to a ckanext-neso action (resource_metadata_show) and a CKAN download
URL. Removes the dump/{id}/metadata route, its service code, the
CKANClient.package_show it needed, tests and docs. dump/{id}/dictionary stays.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resource + dataset metadata export is CKAN data, not datastore data. It now lives in ckanext-neso as the
resource_metadata_showaction with a CKAN download URL (/resource/<id>/metadata?format=csv|json), shipped in datopian/dx-helm-neso@760353b.Removes
dump/{id}/metadata, its service code,CKANClient.package_show(only used by it), the tests and the docs.dump/{id}/dictionarystays.Merge order: after the dx-helm-neso CKAN/frontend change is deployed (already on main), otherwise the Metadata link is briefly broken. Then bump
DATASTORE_REFin dx-helm-neso'sdatastore/Dockerfile.Tests: full suite passes (645), ruff check clean.