Use argparse to process arguments to /source - #2205
Merged
Merged
Conversation
This makes the custom code around /source marginally simpler, though there is still some hard-coding, and it would be better if * argparse was baked in to registering any special command * completions were generated entirely from the argparse spec Some very minor functionality is gained in the form of recognition of double-dash for option termination, but this is noted in the changelog only as an internal refactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes the custom code around
/sourcemarginally simpler, though there is still some hard-coding, and it would be better ifargparsewas baked in to registering any special commandargparsespecSome very minor functionality is gained in the form of recognition of double-dash for option termination, but this is noted in the changelog only as an internal refactor.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).