Fix encoding error when database encoding is ASCII - #1629
Draft
dbaty wants to merge 2 commits into
Draft
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tentative fix of encoding issues (#1405, #1518) by forcing the encoding to utf-8 (to receive strings), even when the database encoding is ASCII (which would return bytes and make pgcli raise exceptions in several places).
I've tried that weeks or months ago (based on this great comment that pinpointed the cause of these long-standing issues). I think I manually tested and verified most of the changes (if not all), but automated tests are lacking. This is just a draft to show a different way of fixing the issue (instead of forcefully and blindly converting bytes to a string, as in #1628).
Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install).