Skip to content

fix(flow): preserve canonical summary facts through handoffs - #182

Merged
vriesd merged 4 commits into
mainfrom
fix/canonical-handoff-boundary
Oct 8, 2026
Merged

vriesd merged 4 commits into
mainfrom
fix/canonical-handoff-boundary

Conversation

@vriesd

@vriesd vriesd commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Why

Qualification repeatedly rejected truthful paraphrases, and faithful copies of the runtime's own default summary also failed. Caller-written closure prose mixed with structured facts in the default handoff.

What changed

  • Derive the default closure row from the recorded kind and retain exact unmet evidence commands and declared platforms.
  • Require all three manager guidance paths to copy the supplied concise summary unchanged.
  • Preserve raw closure narrative, full reports, assurance limits, and external-action authority.

Scope

Delivery formatting, manager handoff guidance, contract documentation, and regression tests. Evaluators, policy, case instructions, sampling, models, and passing requirements remain unchanged.

Tradeoffs

Descriptive closure narrative remains available in full detail. The default summary carries structured facts without asking the manager to reconstruct them.

Blast Radius

Default handoff text changes. The delivery schema and full report stay unchanged. This creates new package bytes and requires fresh qualification before release.

Verification

  • RED regression commits precede GREEN. Loaded guidance and maintained projection checks pass.

  • All 20 eligible canonical summary inputs from 12 retained campaigns pass the unchanged whole checker. Full-detail projections remain identical. Original reports and transcripts are unchanged.

  • Independent review exercised the actual tarball, all three guidance paths, offline closure behavior, and contradiction controls. These checks do not establish live qualification.

  • Full push preflight passed with 2,912 tests passing, 20 existing skips, and zero failures. Path-selected distribution and prompt checks passed. Independent exact-head source, tarball, and comment reviews passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T00:34:04.756986Z 1c58e09 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vriesd
vriesd merged commit a386603 into main Oct 8, 2026
7 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c58e09513

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills/flow-plan/SKILL.md
Comment on lines +35 to +36
- Delivery handoff: Copy `workflowData.delivery.summary.lines` unchanged as one block.
Implementation details may precede the block. Do not rewrite or restate its facts elsewhere.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Apply canonical handoff rules before router error exits

When the initial compact status returns an error carrying workflowData.delivery—notably the archive-collision response from closedArchiveCollisionStatus—the compiled /flow-auto, /flow-plan, and /flow-run prompts in src/prompt-surfaces.ts tell the manager to report only the top-level summary/recovery and stop before loading these guides. Consequently this new instruction is never seen on those recovery paths, and the canonical delivery summary is omitted rather than copied unchanged. Add the delivery handoff requirement to the router error paths or load the applicable guide before exiting.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants