Repository navigation
fix(flow): preserve canonical summary facts through handoffs - #182
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c58e09513
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Delivery handoff: Copy `workflowData.delivery.summary.lines` unchanged as one block. | ||
| Implementation details may precede the block. Do not rewrite or restate its facts elsewhere. |
There was a problem hiding this comment.
Apply canonical handoff rules before router error exits
When the initial compact status returns an error carrying workflowData.delivery—notably the archive-collision response from closedArchiveCollisionStatus—the compiled /flow-auto, /flow-plan, and /flow-run prompts in src/prompt-surfaces.ts tell the manager to report only the top-level summary/recovery and stop before loading these guides. Consequently this new instruction is never seen on those recovery paths, and the canonical delivery summary is omitted rather than copied unchanged. Add the delivery handoff requirement to the router error paths or load the applicable guide before exiting.
Useful? React with 👍 / 👎.
Why
Qualification repeatedly rejected truthful paraphrases, and faithful copies of the runtime's own default summary also failed. Caller-written closure prose mixed with structured facts in the default handoff.
What changed
Scope
Delivery formatting, manager handoff guidance, contract documentation, and regression tests. Evaluators, policy, case instructions, sampling, models, and passing requirements remain unchanged.
Tradeoffs
Descriptive closure narrative remains available in full detail. The default summary carries structured facts without asking the manager to reconstruct them.
Blast Radius
Default handoff text changes. The delivery schema and full report stay unchanged. This creates new package bytes and requires fresh qualification before release.
Verification
RED regression commits precede GREEN. Loaded guidance and maintained projection checks pass.
All 20 eligible canonical summary inputs from 12 retained campaigns pass the unchanged whole checker. Full-detail projections remain identical. Original reports and transcripts are unchanged.
Independent review exercised the actual tarball, all three guidance paths, offline closure behavior, and contradiction controls. These checks do not establish live qualification.
Full push preflight passed with 2,912 tests passing, 20 existing skips, and zero failures. Path-selected distribution and prompt checks passed. Independent exact-head source, tarball, and comment reviews passed.