Conversation
The footer already used margin-top: auto, but #root was a block container so the rule had no effect and the footer floated under short content. Making #root a full-height flex column lets the footer sit at the bottom of the viewport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a view has little content (for example the Issues tab with filters that match nothing), the footer sits right under the content and leaves an empty band below it instead of reaching the bottom of the window.
.app-footeralready hasmargin-top: auto, but that only pushes an element down inside a flex container. Its parent,#root, was a plain block, so the rule had no effect.Fix
Make
#roota full-height flex column insrc/styles/base.css:The footer's existing
margin-top: autonow pushes it to the bottom of the viewport on short pages. Long pages scroll as before, with the footer after the content. The sticky top bar and sidebar, board focus mode, and the auth screen are unaffected.Testing
npm run buildpasses.Screenshots
Before

After
