Skip to content

Give the dashboard and the form editor the same top bar height - #300

Merged
PhilReinking merged 3 commits into
mainfrom
fix/bits-390-top-bar-height
Oct 22, 2026
Merged

PhilReinking merged 3 commits into
mainfrom
fix/bits-390-top-bar-height

Conversation

@PhilReinking

@PhilReinking PhilReinking commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

The top bar was 64 px high on the dashboard and 56 px in the form editor, so it jumped between them. Both now use one height, h-bar (3.5rem, set once in tailwind.config.js). From 1024 px the dashboard bar's side padding matches the form bar too.

Fixes BITS-390.

Tested: Vitest, lint, vue-tsc and build are green; the new test fails on main. Measured 1440 and 390 in a browser: dashboard 64 → 56 px, editor 56 px.

Known detail: on phones the account button sits 12 px further left on the dashboard than in the editor.

🤖 Generated with Claude Code

PhilReinking and others added 2 commits October 22, 2026 16:10
Both bars use the new h-bar height (3.5rem) instead of h-16 and h-14. The dashboard bar's side padding now matches the form bar from lg.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@PhilReinking PhilReinking left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK at e212068 (CI: the PM checks it). Nothing in resources/js depends on the old 64 px. The tallest item in the dashboard bar is 44 px (h-11). The account dropdown sits outside the bar and nav has no overflow, so nothing is clipped. At 1440 both bars line up. The 12 px on phones comes from px-4 vs px-1. On phones the two bars hold different controls anyway, so I don't count it as a jump.

@PhilReinking PhilReinking left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still OK at 8e8ff52 (CI: the PM checks it). The merge of main changes none of this PR's files. The PR still changes the same 5 files. CHANGELOG.md keeps #300, #299 and #298 under [Unreleased] → Fixed.

@PhilReinking
PhilReinking merged commit 9b37d74 into main Oct 22, 2026
5 checks passed
@PhilReinking
PhilReinking deleted the fix/bits-390-top-bar-height branch October 22, 2026 14:45
@PhilReinking PhilReinking mentioned this pull request Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant