Repository navigation
Show whether the preview is open on the Preview button - #301
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PhilReinking
commented
Oct 22, 2026
PhilReinking
left a comment
PhilReinking
left a comment
Contributor
Author
There was a problem hiding this comment.
OK at 4f6564f (CI: the PM checks it). Contrast: dark text and icon (slate-900) on white is 17.9:1, on the grey-100 hover 16.3:1. The icon uses fill-current, so it turns dark too. The blue-500 focus ring is 3.7:1 against the white fill and 4.0:1 against the bar, both above 3:1. The closed state's classes are the same as before. Phones are unchanged (hidden … lg:flex).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Preview button in the editor top bar looked almost the same open and closed. While the preview is open it now has a white fill with dark text and icon, like a pressed toggle. Closed stays dark with a thin border.
aria-pressedstays, and hover and focus rings show in both states.Fixes BITS-391.
Tested: Vitest, lint, vue-tsc and build are green; the new test fails on main. Checked at 1440 in a browser: open, closed, hover and focus.
Known gap: from 1024 to 1279 px the preview opens over the button, so Esc closes it (not in this ticket).
🤖 Generated with Claude Code