Skip to content

[deckhouse-cli] Backport --since-version fix to 0.33 - #513

Open
Glitchy-Sheep wants to merge 1 commit into
release-1.33from
fix/mirror-pull-since-version-backport-to-0.33
Open

Glitchy-Sheep wants to merge 1 commit into
release-1.33from
fix/mirror-pull-since-version-backport-to-0.33

Conversation

@Glitchy-Sheep

@Glitchy-Sheep Glitchy-Sheep commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Note

Backport of the --since-version fix from #510 to release-1.33 (CLI 0.33).

Summary

Users of CLI 0.33 can now include older platform releases in a mirror bundle with --since-version.

Problem

  • The command parses the flag but never passes its value to platform discovery.
  • The platform code also uses the later version as the lower bound, contrary to the documented behavior.

Fix

  • Pass the requested version from the command through the pull service to platform discovery.
  • Use the earlier of Rock Solid and the requested version as the inclusive lower bound.
  • Keep the latest patch per minor and the release-channel versions within the selected range.
  • Update the documentation to explain how the flag extends the default range.

Before / After

With Rock Solid at 1.68.0:

Flag Before After
--since-version 1.67.0 Lower bound stays at 1.68.0 Lower bound moves to 1.67.0
--since-version 1.70.0 Lower bound stays at 1.68.0 Lower bound stays at 1.68.0

Tests

  • TestPullCommandSinceVersion covers the real command, version boundaries, and conflicting flags.
  • Platform tests cover latest patches, release-channel versions, and LTS-only registries.
  • CI checks pass: Test, Lint, Build for PR, and DCO.

Signed-off-by: Roman Berezkin <roman.berezkin@flant.com>
@Glitchy-Sheep Glitchy-Sheep self-assigned this Oct 13, 2026
@Glitchy-Sheep Glitchy-Sheep changed the title [mirror] Backport --since-version fix to 0.33 [deckhouse-cli] Backport --since-version fix to 0.33 Oct 14, 2026
@Glitchy-Sheep
Glitchy-Sheep marked this pull request as ready for review October 14, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant