Skip to content

[LTS] Skip precommit for CI and add missing hint - #7372

Merged
mohanchen merged 4 commits into
deepmodeling:LTSfrom
Growl1234:LTS
Jun 18, 2026
Merged

mohanchen merged 4 commits into
deepmodeling:LTSfrom
Growl1234:LTS

Conversation

@Growl1234

Copy link
Copy Markdown

No description provided.

@Growl1234 Growl1234 changed the title [LTS] Ignore precommit error and add a missing hint [LTS] Skip precommit and add missing hint May 21, 2026
@Growl1234 Growl1234 changed the title [LTS] Skip precommit and add missing hint [LTS] Skip precommit for CI and add missing hint May 21, 2026
@Growl1234

Growl1234 commented May 22, 2026 •

Copy link
Copy Markdown
Author

Anyone knows how to deal with this test failure, which appearently has nothing to do with this PR?

[ RUN      ] 204_NO_KP_NC
[----------] non-collinear Fe Anti-ferromagnetic and lcao basis calculation
[Warning:   ]  etotref cal=-6436.21478610 ref=-6436.21478589 deviation=0.00000021
[Warning:   ]  etotperatomref cal=-3218.10739305 ref=-3218.10739294 deviation=0.00000011

@mohanchen mohanchen added the Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS label May 24, 2026
@Growl1234

Copy link
Copy Markdown
Author

Gentle ping :)
It seems this PR has not received any attention for more than a week...

@mohanchen

Copy link
Copy Markdown
Collaborator

Gentle ping :) It seems this PR has not received any attention for more than a week...

Thx for the reminder. The integration tests and unit tests failed, could you take a look?

@Growl1234

Growl1234 commented May 30, 2026 •

Copy link
Copy Markdown
Author
[WARNING   ]  etotref cal=-6436.21478610 ref=-6436.21478589 deviation=0.00000021
[WARNING   ]  etotperatomref cal=-3218.10739305 ref=-3218.10739294 deviation=0.00000011

I suspect, this is more likely a case where the test issue was previously hidden because the CI workflow failed before the build stage, and it only became visible this time because the previous failure point was skipped.

Given this test result, however, I would personally prefer to relax the tolerance...

@Growl1234

Copy link
Copy Markdown
Author

Strangely, I could not reproduce the deviation on my computer with current LTS branch...

Would it be acceptble to relax the tolerance to 3e-07 only for 204_NAO_KP_NC?

@Growl1234

Growl1234 commented May 30, 2026 •

Copy link
Copy Markdown
Author

And it seems some other tests will have error on my machine (with gcc-mkl toolchain, except the PAW case because it's not enabled on my build...): test.log
but such non-reproduceable case never happened with the tests in develop branch...

@mohanchen
mohanchen requested a review from dyzheng June 5, 2026 22:19
@mohanchen mohanchen added the Long-Time Support (LTS) Issues related to LTS version label Jun 5, 2026
@Growl1234

Copy link
Copy Markdown
Author

Looks like this PR gets stuck...

@mohanchen

Copy link
Copy Markdown
Collaborator

We will review this soon.

@mohanchen
mohanchen removed the request for review from dyzheng June 16, 2026 04:59
@mohanchen
mohanchen merged commit 265f1e2 into deepmodeling:LTS Jun 18, 2026
19 checks passed
@Growl1234
Growl1234 deleted the LTS branch July 8, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS Long-Time Support (LTS) Issues related to LTS version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants