Repository navigation
Conversation
AsTonyshment
left a comment
Collaborator
There was a problem hiding this comment.
Overall thanks for your contribution. I heard @ESROAMER talked about this normalization issue at the ABACUS annual conference. Here are some preliminary comments that we should resolve first, and I'll look into your PR in detail in the near future.
ABACUS-PR-BOT
left a comment
Collaborator
There was a problem hiding this comment.
Static review of 11ee6f9a8904c85b7d4be52cb1f5f0e9ea56596e completed with an independent second review. No actionable findings in the endpoint-overlap change, its caller/lifecycle paths, or the regression tests. Whitespace and governance checks passed; metadata/documentation warnings were assessed. This review was static: runtime behavior, updated numerical references, and CI remain unverified.
mohanchen
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
LCAO RT propagation averages H/S for its half-step solve, but previously reused that averaged S for normalization. Normalize the arriving wavefunctions with the endpoint
S(t+dt)instead: the CPU path uses the existing endpoint matrix and the tensor path reloads its existing endpoint host buffer before normalization. No propagation formula, INPUT setting, or comparison tolerance changes.This corrects sHG and moving-ion length/velocity-gauge cases with changing overlap. Constant-overlap cases retain the previous result.
Regression reference updates
Update 50 energy/force/stress reference values across 13 affected cases, the WFC-magnitude reference in
02_NO_CH_OW_TDDFT, and the current reference in16_NO_vel_TDDFT. Preserve all test INPUT/STRU/KPT files, thresholds, comparison scripts and timing references.A controlled moving-ion H2 check evaluated from saved WFC and endpoint S gives a final maximum per-band norm defect of
1.8658e-3before the fix and2.5313e-14after it. Freezing the ions makes the paired energies identical. The old executable matches the old references and the corrected executable reproduces the CI differences. These checks support the reference updates without asserting accuracy of the full moving-ion RT discretization.Validation
ENABLE_FLOAT_FFTW=ON.CASES_CPU.txtsuite: all 28 cases and 115 property comparisons passed with 4 MPI x 1 OMP; repeated with 2 MPI x 1 OMP against the same references, also all passed.bash ../integrate/Autotest.sh -a /tmp/upstream-norm-review-20261014/abacus_basic_para -n 4 -o 1 -j 1 -f CASES_CPU.txt, repeated with-n 2.MODULE_LCAO_tddft_evolve_psi_testandMODULE_LCAO_tddft_norm_psi_test: 2/2 CTests, 4/4 GoogleTests passed.--fail-on-warning), governance checks andgit diff --check: passed. The two Read the Docs checks passed after the heading/toctree correction.