Skip to content

Add Native Windows Support - #8542

Open
nithin-aashik-mcw wants to merge 19 commits into
deepspeedai:masterfrom
nithin-aashik-mcw:feature/windows-support
Open

nithin-aashik-mcw wants to merge 19 commits into
deepspeedai:masterfrom
nithin-aashik-mcw:feature/windows-support

Conversation

@nithin-aashik-mcw

Copy link
Copy Markdown

Summary

Adds native Windows support to DeepSpeed: the CPU-side extension ops (pin_memory, async_io/AIO, and the shared-memory comm backend) now build and run under MSVC, the op_builder/build system and build_win.bat support compiling these ops on Windows, and the unit test harness is runnable on Windows. Also fixes a handful of Windows-specific runtime bugs (paths, timers, MSVC OpenMP loop signedness, header include order) and a few unrelated test flakiness issues found along the way, and adds Windows CI and release wheel-build workflows.

Closes #7276
Closes #7057
Relates to #7744, #7523, #7341

Test plan

  • Windows (x64, arm64) CI job (windows-torch-latest.yml) passes
  • Unit test suite run on Windows (tests/unit)
  • Windows wheel build succeeds via the release workflow

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 244dd3e463

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread op_builder/cpu/async_io.py
Comment thread csrc/aio/common/deepspeed_aio_common.cpp Outdated
@nithin-aashik-mcw

Copy link
Copy Markdown
Author

@codex review

@nithin-aashik-mcw

Copy link
Copy Markdown
Author

@tohtana @loadams @tjruwase
Could you please take a look at this PR when you get a chance? It adds native Windows support, including x64/ARM64 CI, CPU ops, and Windows wheel builds. I’d appreciate maintainer feedback and review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Install to Windows - fatal error LNK1181 [REQUEST] Publish your Windows Wheels build workflow

1 participant