Add Native Windows Support - #8542
Open
nithin-aashik-mcw wants to merge 19 commits into
Open
nithin-aashik-mcw wants to merge 19 commits into
nithin-aashik-mcw wants to merge 19 commits into
Conversation
nithin-aashik-mcw
requested review from
loadams,
tjruwase and
tohtana
as code owners
September 16, 2026 14:42
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 244dd3e463
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Author
|
@codex review |
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds native Windows support to DeepSpeed: the CPU-side extension ops (
pin_memory,async_io/AIO, and the shared-memorycommbackend) now build and run under MSVC, the op_builder/build system andbuild_win.batsupport compiling these ops on Windows, and the unit test harness is runnable on Windows. Also fixes a handful of Windows-specific runtime bugs (paths, timers, MSVC OpenMP loop signedness, header include order) and a few unrelated test flakiness issues found along the way, and adds Windows CI and release wheel-build workflows.Closes #7276
Closes #7057
Relates to #7744, #7523, #7341
Test plan
windows-torch-latest.yml) passestests/unit)