Split pin_memory benches into per-experiment folders - #1015
Open
sfc-gh-truwase wants to merge 1 commit into
Open
sfc-gh-truwase wants to merge 1 commit into
sfc-gh-truwase wants to merge 1 commit into
Conversation
Keep ZeRO-3 offload as model_tensor_offload (with --zero-stage) and add activation, H2D/D2H, and optional harnesses so one DSE tree covers the pinned-offload blog matrix. Root zero3_offload_bench.py still delegates to the ZeRO-3 path. Signed-off-by: tunji-ruwase_snow <tunji.ruwase@snowflake.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benchmarks/pin_memoryinto subfolders:model_tensor_offload,activation_offload,h2d_d2h, plus optionalgrad_offload,cpu_pin,deepcompile_activation.common.py. Rootzero3_offload_bench.pystill runs ZeRO-3 model-tensor offload.--skip-native-registerfor XPU withoutregister_host_memory.Test plan
python model_tensor_offload/bench.py --hidden 256 --layers 2 --batch 1 --seq 32 --steps 1 --warmup 0on CUDApython activation_offload/bench.py --hidden 64 --layers 2 --seq 32 --steps 1 --warmup 0on CUDApython h2d_d2h/bench.py --sizes-mib 4 --warmup 1 --iters 2python zero3_offload_bench.py --hidden 256 --layers 2 --batch 1 --seq 32 --steps 1 --warmup 0(compat shim)Made with Cursor