Repository navigation
fix(ini): merge repeated sections instead of dropping earlier keys - #7361
Open
Harsh23Kashyap wants to merge 1 commit into
Open
Harsh23Kashyap wants to merge 1 commit into
Harsh23Kashyap wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7361 +/- ##
==========================================
- Coverage 95.04% 95.04% -0.01%
==========================================
Files 619 618 -1
Lines 52012 51765 -247
Branches 9450 9405 -45
==========================================
- Hits 49434 49199 -235
+ Misses 2031 2022 -9
+ Partials 547 544 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7360.
When the same section header appears twice,
parsereplaces the first section's object with a fresh one, so every key from the earlier occurrence vanishes without an error:With this change a repeated section name reuses the existing section object, so the keys merge. That matches what node-ini does, and it composes with the rules
parsealready pins elsewhere: a key repeated across the two occurrences still resolves last-assignment-wins (same as a repeated key within one section), and a top-level key sharing the section's name is still replaced by the section.Python's configparser raises
DuplicateSectionErrorfor this instead. Merging felt like the better fit here sinceparsenever throws for repeated content anywhere else.Tests added for the merge, the last-wins key case, and the top-level key collision.
deno test -A ini/,deno lint ini/, anddeno fmt --check ini/all pass.