Repository navigation
Conversation
Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7363 +/- ##
==========================================
+ Coverage 95.04% 95.06% +0.02%
==========================================
Files 619 618 -1
Lines 52012 51763 -249
Branches 9450 9407 -43
==========================================
- Hits 49434 49208 -226
+ Misses 2031 2014 -17
+ Partials 547 541 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
condenseFlow: true,stringify()wrapped every flow mapping key in double quotes, including keys that were already serialized as quoted scalars.{ "1": 1 }became{"'1'":1}, which parses back as{ "'1'": 1 }, and keys such asa"bora\nbproduced output thatparse()rejects. Plain keys were wrapped without escaping, so a plain key containing a backslash changed meaning, and the?marker for keys over 1024 characters ended up inside the quotes.This change leaves keys that are already quoted as they are, escapes plain keys before wrapping them in double quotes, and keeps the
?marker outside the key.Added a test covering the affected keys and a round trip through
parse().deno task testforyamlanddeno fmt --check/deno lintpass.Fixes #7362