record resource changes from previous to desired - #171
Merged
Merged
Conversation
- compare each resource with the previous release, not the live cluster - drop prediction, diagnostics, and apply details from the semantic plan - order creates and updates like helm, then deletes in previous order
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deployah planstill uses the older plan. This does not change that command.Related
Refs #142
Refs #143
Test plan
scenarios/(if behavior changes)nix run .#lint/ pre-commit cleanPre-commit ran gofmt, golangci-lint, and the other hooks.
go test ./internal/plan/... -racepassed. The e2e test compiles. It was not run against a Kind cluster.Labels
kind/feature,kind/bug,kind/docs,kind/chorebreaking-changeif this breaks existing CLI or config behaviorskip-changelogfor internal-only PRs that should not appear in notesChecklist
README.md,docs/cli/)