Skip to content

add drift from previous to live - #173

Merged
atkrad merged 1 commit into
mainfrom
add-semantic-drift
Sep 28, 2026
Merged

atkrad merged 1 commit into
mainfrom
add-semantic-drift

Conversation

@atkrad

@atkrad atkrad commented Sep 28, 2026

Copy link
Copy Markdown
Member

Summary

  • An existing release now reports drift from the stored manifest to live objects.
  • Drift only gets and lists. It does not change the Helm action, resource changes, tasks, or summary.
  • A fresh install does not read the cluster. deployah plan still uses the older plan.

Test plan

  • Unit tests added/updated
  • Scenario under scenarios/ (if behavior changes)
  • nix run .#lint / pre-commit clean
  • Manual smoke (command + expected result), if user-facing

Pre-commit ran gofmt, golangci-lint, and the other hooks. go test ./internal/plan/... passed, including -race. The e2e test compiles. It was not run, because the current kubectl context is a production cluster.

Labels

  • One of: kind/feature, kind/bug, kind/docs, kind/chore
  • Add breaking-change if this breaks existing CLI or config behavior
  • Add skip-changelog for internal-only PRs that should not appear in notes

Checklist

  • Title is short and imperative (matches commit style)
  • Docs / CLI help updated when user-facing (README.md, docs/cli/)
  • No secrets or local-only paths in the diff

- read live objects with get and list only
- keep drift separate from helm actions and resource changes
- show drift in the human and json plan
@atkrad atkrad added kind/feature New capability area/deploy Deploy and plan session flow skip-changelog Exclude this PR from release notes labels Sep 28, 2026
@github-actions github-actions Bot added the kind/docs Documentation only label Sep 28, 2026
@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

@atkrad atkrad removed the kind/docs Documentation only label Sep 28, 2026
@atkrad atkrad self-assigned this Sep 28, 2026
@atkrad
atkrad merged commit 376d00d into main Sep 28, 2026
17 checks passed
@atkrad
atkrad deleted the add-semantic-drift branch September 28, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/deploy Deploy and plan session flow kind/feature New capability skip-changelog Exclude this PR from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant