Skip to content

add chart crds to human plan view - #176

Merged
atkrad merged 3 commits into
mainfrom
add-human-chart-crd-section
Sep 30, 2026
Merged

atkrad merged 3 commits into
mainfrom
add-human-chart-crd-section

Conversation

@atkrad

@atkrad atkrad commented Sep 30, 2026

Copy link
Copy Markdown
Member

Summary

  • Human plan output now has a Chart CRDs section after Resources and before Tasks.
  • Each entry shows the chart CRD name, source file, and Helm lifecycle: process on install, skip when install-time processing is off, or upgrade when Helm will not process the chart CRD.
  • Chart CRDs stay out of the resource summary. JSON output is unchanged. The public deployah plan command still uses the legacy renderer, so CLI docs are unchanged.

Test plan

  • Unit tests added/updated
  • Scenario under scenarios/ (if behavior changes)
  • nix run .#lint / pre-commit clean
  • Manual smoke (command + expected result), if user-facing

Labels

  • One of: kind/feature, kind/bug, kind/docs, kind/chore
  • Add breaking-change if this breaks existing CLI or config behavior
  • Add skip-changelog for internal-only PRs that should not appear in notes

Checklist

  • Title is short and imperative (matches commit style)
  • Docs / CLI help updated when user-facing (README.md, docs/cli/)
  • No secrets or local-only paths in the diff

- show helm lifecycle after resources
- keep chart crds out of resource counts
- cover process, skip, upgrade, and roles
@atkrad atkrad added kind/feature New capability area/deploy Deploy and plan session flow skip-changelog Exclude this PR from release notes labels Sep 30, 2026
@atkrad atkrad self-assigned this Sep 30, 2026
@atkrad atkrad removed the skip-changelog Exclude this PR from release notes label Sep 30, 2026
@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/plan/view/human.go 95.91% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@atkrad
atkrad merged commit a6a0597 into main Sep 30, 2026
17 checks passed
@atkrad
atkrad deleted the add-human-chart-crd-section branch September 30, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/deploy Deploy and plan session flow kind/feature New capability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant