remove unreachable legacy plan stack - #178
Merged
Merged
Conversation
- delete the old plan engine and drift package - drop fixtures that only tested that engine - keep LastSuccessfulRelease for deploy guards
atkrad
added
the
kind/chore
github-actions
Bot
added
area/testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/driftpackage, and thescenarios/plan-*fixtures.deployah planalready uses the semantic planner from switch plan command to semantic planner #177.LastSuccessfulReleasestays for the deploy hostname and workload guards.Related
Refs #177
Test plan
scenarios/(if behavior changes)nix run .#lint/ pre-commit cleannix run .#test-unit,nix run .#test-integration, andnix run .#test-e2eLabels
kind/feature,kind/bug,kind/docs,kind/chorebreaking-changeif this breaks existing CLI or config behaviorskip-changelogfor internal-only PRs that should not appear in notesChecklist
README.md,docs/cli/)