Skip to content

feat: add German nobility titles#188

Merged
derek73 merged 1 commit into
masterfrom
feat/german-nobility-titles
Jun 30, 2026
Merged

feat: add German nobility titles#188
derek73 merged 1 commit into
masterfrom
feat/german-nobility-titles

Conversation

@derek73

@derek73 derek73 commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds 12 German/Austrian nobility and ecclesiastical titles to TITLES: edler, erzbischof, fräulein, freifrau, freiherr, fürst, fürsterzbischof, großfürst, herzog, prinz, reichsgraf, ritter
  • Sourced from PR #101 by @skurzinz, which drew on 19th-century Austrian government nobility titles
  • Skipped the duplicate curly-quote variants of chargé d'affaires, king's, and queen's that were included in added more german nobility titles #101 (straight-quote forms already present)
  • All titles inserted in alphabetical order, consistent with the file's conventions

Test plan

  • All 956 existing tests pass (python -m pytest -q)
  • Manual spot-check: HumanName("Fürst Karl von Schwarzenberg").title'Fürst'

Closes #101

🤖 Generated with Claude Code

Adds 12 German/Austrian nobility and ecclesiastical titles sourced from
PR #101 (skurzinz), skipping the duplicate curly-quote variants already
present: edler, erzbischof, fräulein, freifrau, freiherr, fürst,
fürsterzbischof, großfürst, herzog, prinz, reichsgraf, ritter.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@derek73 derek73 self-assigned this Jun 30, 2026
@derek73 derek73 added this to the v1.3.0 milestone Jun 30, 2026
@derek73 derek73 merged commit c090fed into master Jun 30, 2026
8 checks passed
@derek73 derek73 deleted the feat/german-nobility-titles branch June 30, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant