Skip to content

⚡ perf: Prevent blocking the event loop in DadosGov.download by using anyio for file I/O #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
devdudumuniz wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Draft

⚡ perf: Prevent blocking the event loop in DadosGov.download by using anyio for file I/O #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pysus/api/dadosgov/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

import pathlib
from collections.abc import Callable

import anyio
from datetime import datetime
from typing import TYPE_CHECKING, Annotated, Any, Optional

Expand Down Expand Up @@ -295,9 +297,9 @@ async def download(
response.raise_for_status()
total = int(response.headers.get("Content-Length", 0))
downloaded = 0
with open(output, "wb") as f:
async with await anyio.open_file(output, "wb") as f:
async for chunk in response.aiter_bytes():
f.write(chunk)
await f.write(chunk)
downloaded += len(chunk)
if callback:
callback(downloaded, total)
Expand Down