feat: add bubblewrap to UDI 9 / 10#262
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughBubblewrap 0.11.2 is downloaded, checksum-verified, compiled with Meson and Ninja, and installed with setuid permissions in the universal UBI 9 and UBI 10 Dockerfiles. Build dependencies and DNF cache data are removed afterward. ChangesUniversal image bubblewrap builds
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi! I'm che-ai-assistant — I help with your pull requests. Available commands:
|
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@universal/ubi9/Dockerfile`:
- Around line 583-584: Remove gcc from the dnf remove list in both bubblewrap
cleanup blocks, preserving removal of meson, ninja-build, and libcap-devel.
Update universal/ubi9/Dockerfile lines 583-584 and universal/ubi10/Dockerfile
lines 616-617; no other cleanup behavior should change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9a014407-478e-40ea-b04b-1efce9ecc203
📒 Files selected for processing (2)
universal/ubi10/Dockerfileuniversal/ubi9/Dockerfile
| dnf remove -y meson ninja-build gcc libcap-devel | ||
| dnf clean all && rm -rf /var/cache/dnf |
There was a problem hiding this comment.
🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win
dnf remove includes gcc in both Dockerfiles — breaks the C/C++ toolchain installed earlier. Both bubblewrap blocks remove gcc via dnf remove, but gcc was installed earlier for the C/C++ toolchain (gcc gcc-c++ at Line 131 in UBI 9, Line 133 in UBI 10). Removing gcc cascades to gcc-c++ (RPM dependency) and potentially php-devel and other -devel packages, breaking the image's developer-tool contract.
universal/ubi9/Dockerfile#L583-L584: Removegccfrom thednf removelist — change todnf remove -y meson ninja-build libcap-devel.universal/ubi10/Dockerfile#L616-L617: Same fix — change todnf remove -y meson ninja-build libcap-devel.
📍 Affects 2 files
universal/ubi9/Dockerfile#L583-L584(this comment)universal/ubi10/Dockerfile#L616-L617
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@universal/ubi9/Dockerfile` around lines 583 - 584, Remove gcc from the dnf
remove list in both bubblewrap cleanup blocks, preserving removal of meson,
ninja-build, and libcap-devel. Update universal/ubi9/Dockerfile lines 583-584
and universal/ubi10/Dockerfile lines 616-617; no other cleanup behavior should
change.
|
Pull Request UBI 10 images published ✨ Base: quay.io/devfile/base-developer-image:ubi10-pr-262 |
|
Pull Request images published ✨ Base: quay.io/devfile/base-developer-image:pr-262 |
https://github.com/containers/bubblewrap - Low-level unprivileged sandboxing tool used by Flatpak and similar projects
Summary by CodeRabbit
bwrap) sandboxing to the UBI 9 and UBI 10 container images, installed from a pinned release with integrity verification.