Skip to content

fix(hub-ui): make json-render an optional peer #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antfu merged 1 commit into from
Aug 15, 2026
Merged

fix(hub-ui): make json-render an optional peer #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/hub-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@
"@devframes/json-render": "workspace:*",
"devframe": "workspace:*"
},
"peerDependenciesMeta": {
"@devframes/json-render": {
"optional": true
}
},
"devDependencies": {
"@antfu/design": "catalog:frontend",
"@devframes/hub": "workspace:*",
Expand Down
7 changes: 6 additions & 1 deletion packages/hub-ui/src/client/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import type { DevframeViewLauncher } from '@devframes/hub/types'
// Importing the hub-mounted json-render integration registers its
// `'json-render'` dock entry (a serializable `view` ref, not a live handle)
// on the hub's open dock union via declaration merging.
// on the hub's open dock union via declaration merging. This has to be a
// value import, not `import type`, because TS rejects a type-only
// side-effect import (no bindings to mark as type-only) — but it's still
// fully erased at build time since nothing in dist ever references it, so
// @devframes/json-render staying an *optional* peer below doesn't change
// what ships.
import '@devframes/json-render/hub'

/**
Expand Down
Loading