feat(plugins): serve every builtin plugin's SPA from a lockstep assets package - #244
Merged
Conversation
…s package Extends the deferred-assets pattern (piloted on plugin-inspect) to all remaining builtin plugins: og, data-inspector, code-server, assets, messages, terminals, a11y, and git. Each plugin's iframe SPA now ships in a lockstep `@devframes/plugin-<name>--assets` package instead of the node tarball — the Vite build (or git's Next export) emits into assets-pkg/dist, and cli.distDir points at a RemoteAssets declaration. Panel clientScript bundles (messages/terminals dist/client) and a11y's dist/inject agent stay in their node packages. Each plugin declares its `--assets` package as an optional peer dependency (so it resolves when a consumer installs it) alongside the dev-only workspace link (so resolveFrom finds the local build in the monorepo); this optional-peer declaration is also added to the inspect pilot. Wires per-plugin turbo outputs (assets-pkg/dist), knip overrides, and updates each plugin's test harness to resolve the SPA via resolveStaticAssetsSource.
antfubot
force-pushed
the
feat/plugins-assets
branch
from
August 17, 2026 01:52
8a1e85e to
aa3d2e1
Compare
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #239
Base branch is
feat/plugin-inspect-client(#239 → #236). Extends the inspect pilot to every remaining builtin plugin.What
Each builtin plugin's iframe SPA now ships in a lockstep
@devframes/plugin-<name>--assetspackage instead of the node tarball, served on demand through the remote-assets back-proxy. Converted: og, data-inspector, code-server, assets, messages, terminals, a11y, git.plugins/<name>/assets-pkg/dist.cli.distDirpoints at aRemoteAssetsdeclaration ({ package, version, resolveFrom }).clientScriptbundles (messages/terminalsdist/client) and a11y'sdist/injecthost-page agent stay in their node packages — only the iframe SPA moves.Optional peer dependency
Each plugin declares its
--assetspackage as an optional peer dependency (peerDependenciesMeta.optional) so it resolves cleanly when a consumer installs it, alongside the dev-onlyworkspace:*link that letsresolveFromfind the local build in this monorepo. This optional-peer declaration is also added to the inspect pilot for consistency.Wiring
turbo.json: each plugin build declaresassets-pkg/dist/**as an output (nested-package outputs, cache-restored).knip.jsonc: per-pluginignoreDependencies(the--assetsstring ref) + assets-only package overrides.resolveStaticAssetsSource(monorepo link → local dir).pnpm-workspace.yaml'splugins/*/assets-pkgglob (from feat(plugin-inspect): serve the SPA from a lockstep assets package #239) already covers the new packages.Verification
typecheck 30/30 · unit tests 1162 pass (9 skipped: tsnapi no-exports for the 9 assets-only packages) · lint clean · knip clean · full build green · confirmed each plugin's
dist/spa(git'sdist/client) moved toassets-pkg/distand out of the node package.Created with the help of an agent.