fix(release): route package prepack through turbo - #245
Merged
Conversation
…ps build in order
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
v0.9.0-beta.6release failed duringpnpm -r publish:Every publishable package's
prepackran its own build in isolation (pnpm build→tsdown/vite), never building its workspace dependencies.pnpm -r publishskips packages whose version already exists on npm, so@devframes/vite'sprepacknever ran and itsdist/was absent — yetplugin-inspect's build imports@devframes/vite/single, so it blew up.What
Route each package's
prepackthroughturbo run build --filter=<self>. Turbo honours thedependsOngraph inturbo.json, so building any package first builds its workspace deps in the correct order, and turbo's cache means shared deps (e.g.devframe,@devframes/vite) are built once and restored on cache hit rather than rebuilt per package.Verified locally with a cleaned tree: publishing
@devframes/plugin-inspectfirst now buildsdevframe → hub → hub-ui → vite → plugin-inspectin order, and subsequent packages'prepackcache-hit the shared deps (e.g.plugin-og: 4 cached, 1 built).This PR was created with the help of an agent.