test: update stale remote-assets runtime API snapshot - #248
Merged
Conversation
resolveStaticAssetsSource is now imported by multiple entry points (adapters/initiate, adapters/build, node/host-views) in addition to being its own entry, so rolldown's multi-entry code-splitting hoists it into a shared chunk and utils/remote-assets.mjs re-exports it instead of declaring it inline. The signature is unchanged; only the prior snapshot fix (2838098) missed this entry's runtime snapshot.
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/exports.test.ts > devframe > runtime: ./utils/remote-assetswas failing: the runtime API snapshot fordevframe/utils/remote-assetsstill expected an inline function declaration, but the built output now re-exports the function from a shared chunk.Why
resolveStaticAssetsSourceis imported from multiple entry points (adapters/initiate.ts,adapters/build.ts,node/host-views.ts) in addition to being its own entry, so rolldown's multi-entry code-splitting hoists it into a shared chunk —utils/remote-assets.mjsnow doesexport { resolveStaticAssetsSource }instead of declaring it inline. The exported function's signature/arity is unchanged. A prior snapshot-fix commit (2838098e) updated the type-declaration snapshots for the remote-assets changes but missed this entry's runtime.jssnapshot.Change
Regenerated the stale
tests/__snapshots__/tsnapi/devframe/utils/remote-assets.snapshot.jssnapshot to match current build output. The.d.tssnapshot was already correct.Created with the help of an agent.