Repository navigation
ci: tidy MODULE.bazel, repin dx_crates, fixture crate hub on the vendored extension (part of #12277) - #12829
Merged
Conversation
Collaborator
Author
|
Review: approve No must-fix items. The mod tidy reorder is a no-op. The 🤖 Generated with Claude Code |
… the vendored crate extension (part of #12277) workflow-check failed on bazel mod tidy drift and preflight linux_x86_64 on the dx_crates digest in scheduled run 43706723775. The rust fixture hub used the upstream crate extension since #12388, so the repo-wide build-script cc annotation no longer reached it and its lock digest went stale; it now uses //rust/private/crate_universe:extensions.bzl like every other hub. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hzwNN9Q3DFZx18pNic
TrapsterDK
force-pushed
the
fix-12277-ci-dogfood
branch
from
November 16, 2026 09:44
eea6381 to
f48a6fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12277
Scheduled ci.yml run 43706723775 (main 306c43a) failed in workflow-check and preflight linux_x86_64. This PR fixes both:
bazel mod tidydrift in MODULE.bazel (a blank line, plus the order ofpinsindx_windows_sdk_ext.configure). MODULE.bazel is now tidied.cargo-bazel-lock.jsonis repinned in workspace mode: only the checksum changes, with no version bumps.dx_rust_fixture_crates. Since rust: vendor the patched crate_universe extension so consumers need no root BUILD.bazel (part of #12378) #12388,crate_fixtureshad used the upstream@rules_rustcrate extension whilecrateused the vendored//rust/private/crate_universe:extensions.bzl. As a result, the repo-widecrate = "*"build-script cc annotation no longer reached the fixture hub.crate_fixturesnow uses the vendored extension, sorust/tests/cargo-bazel-lock.jsonmatches unchanged.Local (Linux):
bazel mod tidyleaves no diff.bazel mod show_repo --lockfile_mode=error --repo_env=CARGO_BAZEL_DIGEST_CHECK=1 @crates @dx_quality_crates @dx_thrift_cratesexits 0.Not run locally: the full rust fixture test set (stopped at the 20 min budget).
//rust/tests/fixtures/native_call:native_cc_build_script_cross_identity_tests_gccfails analysis locally with "No matching toolchains" for@rules_rust//cargo/private:no_binary; this was not compared against main. Nested-Bazel and consumer tests were not run.Remaining for #12277 (other preflight legs in run 43706723775):
//core/quality/testdata:real_result_ansible_lint_dirty(ansible shims are not found via PATHEXT) and//julia/tests/fixtures/julia-app/cli:cli_testtiming out at 60s.dogfood.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hzwNN9Q3DFZx18pNic