Skip to content

ci: tidy MODULE.bazel, repin dx_crates, fixture crate hub on the vendored extension (part of #12277) - #12829

Merged
TrapsterDK merged 1 commit into
mainfrom
fix-12277-ci-dogfood
Nov 16, 2026
Merged

TrapsterDK merged 1 commit into
mainfrom
fix-12277-ci-dogfood

Conversation

@TrapsterDK

Copy link
Copy Markdown
Collaborator

Part of #12277

Scheduled ci.yml run 43706723775 (main 306c43a) failed in workflow-check and preflight linux_x86_64. This PR fixes both:

  • workflow-check: bazel mod tidy drift in MODULE.bazel (a blank line, plus the order of pins in dx_windows_sdk_ext.configure). MODULE.bazel is now tidied.
  • preflight linux_x86_64: the dx_crates lock digest was stale. cargo-bazel-lock.json is repinned in workspace mode: only the checksum changes, with no version bumps.
  • With dx_crates fixed, the digest check went on to fail on dx_rust_fixture_crates. Since rust: vendor the patched crate_universe extension so consumers need no root BUILD.bazel (part of #12378) #12388, crate_fixtures had used the upstream @rules_rust crate extension while crate used the vendored //rust/private/crate_universe:extensions.bzl. As a result, the repo-wide crate = "*" build-script cc annotation no longer reached the fixture hub. crate_fixtures now uses the vendored extension, so rust/tests/cargo-bazel-lock.json matches unchanged.

Local (Linux): bazel mod tidy leaves no diff. bazel mod show_repo --lockfile_mode=error --repo_env=CARGO_BAZEL_DIGEST_CHECK=1 @crates @dx_quality_crates @dx_thrift_crates exits 0.
Not run locally: the full rust fixture test set (stopped at the 20 min budget). //rust/tests/fixtures/native_call:native_cc_build_script_cross_identity_tests_gcc fails analysis locally with "No matching toolchains" for @rules_rust//cargo/private:no_binary; this was not compared against main. Nested-Bazel and consumer tests were not run.

Remaining for #12277 (other preflight legs in run 43706723775):

  • windows_x86_64: //core/quality/testdata:real_result_ansible_lint_dirty (ansible shims are not found via PATHEXT) and //julia/tests/fixtures/julia-app/cli:cli_test timing out at 60s.
  • windows_arm64: matrix_pkl_lint_* timeouts (may be fixed by quality: build tree-sitter natives for pkl-lsp on windows_arm64 (part of #12277) #12806) and matrix_latex_format_pass.
  • macos_arm64: the preflight job was cancelled at the job timeout during the launch smoke.
  • A scheduled ci.yml run on main must reach dogfood.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xut2hzwNN9Q3DFZx18pNic

@TrapsterDK

Copy link
Copy Markdown
Collaborator Author

Review: approve

No must-fix items. The mod tidy reorder is a no-op. The crate_fixtures switch to //rust/private/crate_universe:extensions.bzl matches how crate is declared on main, and that path exists. The checksum-only repin matches the description. I did not run Bazel or CI. The remaining #12277 legs are listed in the PR body.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xut2hzwNN9Q3DFZx18pNic

… the vendored crate extension (part of #12277)

workflow-check failed on bazel mod tidy drift and preflight linux_x86_64 on the
dx_crates digest in scheduled run 43706723775. The rust fixture hub used the
upstream crate extension since #12388, so the repo-wide build-script cc
annotation no longer reached it and its lock digest went stale; it now uses
//rust/private/crate_universe:extensions.bzl like every other hub.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hzwNN9Q3DFZx18pNic
@TrapsterDK
TrapsterDK merged commit ead0b64 into main Nov 16, 2026
1 check failed
@TrapsterDK
TrapsterDK deleted the fix-12277-ci-dogfood branch November 16, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Touches review paths; needs a second-session Review: comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant