Skip to content

quality: windows preflight scratch cleanup and ansible case platforms (part of #12277) - #12832

Draft
TrapsterDK wants to merge 2 commits into
mainfrom
fix-12277-preflight-windows
Draft

TrapsterDK wants to merge 2 commits into
mainfrom
fix-12277-preflight-windows

Conversation

@TrapsterDK

@TrapsterDK TrapsterDK commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Part of #12277.

Fixes the two remaining Windows preflight launch-smoke failures from ci.yml run 43839984201:

  • windows_arm64 //core/quality/testdata:matrix_latex_format_pass: tool execution failed for latexindent: scratch cleanup: Access is denied. (os error 5). Scratch::close (core/quality/adapter/src/exec.rs) now clears read-only entries and retries removal with bounded backoff while entries are held (access denied or sharing violation).
  • windows_x86_64 //core/quality/testdata:real_result_ansible_lint_dirty: Failed to find runtime dependency 'ansible' in PATH. ansible_lint is declared unsupported on Windows (ansible/private/quality/ansible_tools.bzl), so the case no longer sets windows_x86_64.

Round 2 (ci.yml run 43848106641 showed latex and ansible fixed; two new Windows preflight failures):

  • windows_arm64 //deploy/private:pypi_probe_verify: the rfc3161_client sdist build (clang-cl, non---msvc path) failed with FileNotFoundError: [WinError 206] The filename or extension is too long launching the deep runfiles venv interpreter. patches/rules_py/pep517_msvc.patch now uses the short base interpreter and the short worktree root (with copied bin dirs) for every Windows sdist build, not only --msvc.
  • windows_x86_64 //julia/tests/fixtures/julia-app/cli:cli_test: TIMEOUT in 60s (45s pass in run 43839984201, timeout on scheduled main 43706723775); it starts a second Julia process, so it is now size = "medium".

Tests (local, linux_x86_64): //julia/tests/fixtures/julia-app/cli:cli_test passes and the rules_py patch applies.
//core/quality/adapter:quality_adapter_test (new close_removes_a_read_only_tree) and //core/quality/testdata:real_result_ansible_lint_dirty pass; clippy and rustfmt aspects clean on the adapter. tools/dx check --affected timed out on unrelated analysis errors (//core/quality/tests/fixtures/consumer_policy:clean_protobuf buf_breaking_against, rules_rust toolchain for dx_rust_fixture_crates). Nested-Bazel and consumer tests not run locally.

Evidence: ci.yml run 43857914373 (pending).

Remaining on #12277:

  • macos_arm64 preflight cancelled at job timeout in the launch smoke.
  • Dispatch ci.yml on main and confirm it reaches dogfood.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xut2hzwNN9Q3DFZx18pNic

… (part of #12277)

Scratch::close clears read-only entries and retries while entries are
held, so latexindent on windows_arm64 no longer fails with "scratch
cleanup: Access is denied". real_result_ansible_lint_dirty no longer
runs on windows_x86_64, where ansible_lint is declared unsupported.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hzwNN9Q3DFZx18pNic
…builds, julia cli_test medium (part of #12277)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hzwNN9Q3DFZx18pNic

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Touches review paths; needs a second-session Review: comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant