fix: honour the CLI exit code as the run verdict - #9
Merged
Merged
Conversation
The status block overwrote EXIT_CODE unconditionally, so a PASSED rollup
cleared the CLI's own exit 2 ("the run failed, or was cancelled") and the
step went green. CANCELLED also matched neither branch.
Now the CLI's code is kept in CLI_EXIT_CODE and the status block may only
add failures: PASSED clears the step only if the CLI agreed, CANCELLED
fails it, and a non-zero CLI code always fails it.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status block overwrote EXIT_CODE unconditionally, so a PASSED rollup cleared the CLI's own exit 2 ("the run failed, or was cancelled") and the step went green. CANCELLED also matched neither branch.
Now the CLI's code is kept in CLI_EXIT_CODE and the status block may only add failures: PASSED clears the step only if the CLI agreed, CANCELLED fails it, and a non-zero CLI code always fails it.