ci: dual-gate merge policy (static + ThrillhouseBot) (#342)#391
Merged
devops-thiago merged 2 commits intoJul 17, 2026
Conversation
Document complementary static + ThrillhouseBot gates and make the existing Dependency Review workflow a required merge check on dogfood PRs. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
🤖 ThrillhouseBot PR SummaryWhat this PR doesDocuments the dual-gate merge policy for static CI and ThrillhouseBot LLM review, and expands the dependency-review workflow to trigger on develop and release/** branches in addition to main. Changes Overview
Changed Files
Risk Assessment
No new issues found in this PR, but the review cannot be approved until required CI is confirmed green.
|
| Check | Type | Status | Detail |
|---|---|---|---|
| frontend | check-run | ⏳ Pending | - |
| test | check-run | ⏳ Pending | - |
| format | check-run | ⏳ Pending | - |
| dependency-review | check-run | ⏳ Pending | - |
| trivy | missing | ⏳ Pending | - |
Automated review by ThrillhouseBot. Reply with /review to re-run.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Point holds at allow-ghsas / dependency-review-config.yml for that action; keep osv-scanner.toml and .trivyignore for Scorecard/OSV and Trivy. Co-authored-by: Cursor <cursoragent@cursor.com>
![thrillhousebot[bot]](https://avatars.githubusercontent.com/in/3996985?s=60&v=4){kind=small}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Closes the v0.3.1 dual-gate gap from #342: ThrillhouseBot's LLM review and static dependency CI are complementary, not substitutes.
Changes
main/develop/release/**(aligned with CI), with comments tying the job to the dual-gate policy.dependency-reviewadded to required status checks onmain-protectionalongsideformat,test,frontend,trivy.Does not duplicate ThrillhouseBot's LLM pass or implement linters-in-prompt (#34).
Related Issues
Fixes #342
Related: #34 (linters in LLM context — separate), #308 (Jackson GHSA hold pattern), #113, #318
How Has This Been Tested?
Unit tests
Integration tests
Manual testing
Confirmed
main-protectionruleset now requiresdependency-review.Reviewed workflow YAML against existing SHA-pinned action versions.
Docs-only / workflow-metadata change — no Java/frontend unit tests required.
CI on this PR:
dependency-review,format,test,frontend,trivy, Sonar, CodeQL, Codecov all green.Checklist
Screenshots / Logs
N/A — docs + workflow metadata only. Dependency Review summary on this PR: no vulnerabilities or license issues found.
Additional Notes
dependency-reviewis now merge-blocking.