Repository navigation
fix: keep camera ownership consistent and fail switches peers did not take - #427
Merged
Merged
Conversation
… take A switch that lets go of the camera first takes the release from the track, and ends the track when neither camera opens again; the camera cache only drops an entry that is still the camera released. A sender that cannot take the new track, or does not in time, now fails the switch, which goes back to the old camera while it is still open. Replaced tracks are released once no sender uses them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
switchCamera(). The track goes back to the old camera while that is still open, and keeps the new one otherwise.