Repository navigation
Conversation
Handles were looked up on the object's dynamic class, so a subclass field of the same name received the pointer. The lookup now always names the declaring class, checks the instance and caches the field.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native code looked up handle fields on an object's dynamic class, so a subclass declaring a field of the same name (e.g.
long nativeHandlein anAudioResamplersubclass) received the pointer, and its field initializer could overwrite it.GetHandleFieldand the helpers built on it now require the declaring class, check that the object is an instance of it, and cache the field ID.NativeHandle.hbinds the defaultnativeHandletoNativeObject; named handles (observerHandle,processorHostHandle,callbackHandle, the factory's thread handles) name their class.CustomVideoSource.pushFramerejects buffers that are noNativeI420Bufferinstead of reading a field of a Java buffer as a pointer.