Repository navigation
feat: limit and measure the client API's handler threads - #441
Merged
Merged
Conversation
Event and frame pools can be capped with eventThreads and frameThreads; peers and subscriptions take turns of at most 64 tasks or 10 ms, and a limited pool rejects nothing while it runs. WebRtc.loadStats() reports queued, oldest waiting, active and dropped work. The audio buffer of onAudio is set by audioBuffer or per subscription.
# Conflicts: # webrtc/src/main/java/dev/onvoid/webrtc/client/WebRtc.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slow handlers of many peers or subscriptions could take a thread each, and
onAudioalways buffered up to five seconds.WebRtc.Builder.eventThreads(n)andframeThreads(n)cap the pools handlers run on (unlimited by default). The control pool stays unlimited, since its tasks wait for each other.WebRtc.loadStats()reports queued, oldest waiting, active and dropped work for control, events, video and audio, plus the pools' thread counts.Builder.audioBuffer(Duration)or per subscription withonAudio(Duration, handler).