Skip to content

fix: compare the recorded unicode file as a file, not a path, for macOS #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devopvoid merged 1 commit into from
Oct 25, 2026
Merged

fix: compare the recorded unicode file as a file, not a path, for macOS #448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions webrtc-media/src/test/java/dev/onvoid/webrtc/media/recorder/MediaRecorderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.Collections;
import java.util.List;
import java.util.concurrent.CopyOnWriteArrayList;
import java.util.concurrent.CountDownLatch;
Expand Down Expand Up @@ -184,7 +183,13 @@ void recordsIntoPathBeyondBasicPlane() throws Exception {
assertNull(listener.error.get());

try (Stream<Path> files = Files.list(dir)) {
assertEquals(Collections.singletonList(file), files.collect(Collectors.toList()));
List<Path> written = files.collect(Collectors.toList());

// Compared as files, not as paths: on macOS Java holds the name
// decomposed (ü as u and a diaeresis), while FFmpeg writes it as
// given, and the file system finds the file by either form.
assertEquals(1, written.size(), () -> "Written: " + written);
assertTrue(Files.isSameFile(file, written.get(0)), () -> "Written: " + written);
}

assertEquals("vp8", readInfo(file).getVideoCodec());
Expand Down
Loading