Repository navigation
fix: send pushed audio from a thread apart from the timeouts - #452
Merged
Merged
Conversation
The ticks of CustomAudio ran on the runtime's single timer thread, so a slow push into WebRTC delayed operation timeouts, HTTP deadlines and stats. They now run on an audio pacer of their own, and after a stall only ticks at most 50 ms late send, so the missed ticks no longer burst out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CustomAudio ticked on the runtime's single timer thread, so a slow native push delayed operation timeouts, HTTP deadlines and stats. Pushed audio now has its own pacer thread, and after a stall only ticks at most 50 ms late send, so the missed ticks no longer burst out. Queued audio is kept.