Repository navigation
fix: accept custom frame buffers in VideoFrame.copy() and pushFrame() - #455
Merged
Merged
Conversation
Both now take the pixels from toI420() through one native conversion, which shares a NativeI420Buffer and checks the size, strides and plane capacities of any other I420 buffer before copying it.
# Conflicts: # webrtc-jni/src/main/cpp/src/api/VideoFrame.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom
VideoFrameBufferfailed inVideoFrame.copy()with aClassCastExceptionand inCustomVideoSource.pushFrame()with aNoSuchFieldError.Both now take the pixels from
toI420()throughtoNativeBuffer: aNativeI420Bufferreturned there is shared, any other I420 buffer is copied after the plane checks of #454. Copying a releasedNativeI420Buffernow throws instead of reading freed memory.