Repository navigation
fix: stamp custom media pushed without a timestamp on WebRTC's clock - #460
Merged
Merged
Conversation
pushFrame(VideoFrame) and pushAudio() without a timestamp used the time since the SyncClock was created, while the timestamped calls expect webrtc::TimeMicros(). Mixing both made the frame time jump back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CustomVideoSource.pushFrame(VideoFrame)andCustomAudioSource.pushAudio(...)without a timestamp used the time since theirSyncClockwas created, while the timestamped calls expectwebrtc::TimeMicros(). A source mixing both calls saw its frame time jump back (e.g. 16,406,554,481 µs followed by 784 µs).webrtc::TimeMicros(), the clock ofSyncClock.currentTimeUs(); the video NTP capture time is derived as before.