Dev container port-forwarding spec compliance - #887
Draft
skevetter wants to merge 7 commits into
Draft
Conversation
…/openPreview ports
…ing-match other ports
- ResolvePortAttribute: sort portsAttributes keys before the range/regex fallback passes so repeated calls with multiple matching keys return a deterministic result (Go map iteration order is randomized per run). - forwarder.Forward: on devssh.PortForward failure, cancel the port's context and remove it from portMap so the port becomes retryable. - browseronopen_test.go: TestMaybeOpenBrowser_NilOpenedOnceMap_DoesNotPanic now uses AutoForwardOpenBrowserOnce so it actually exercises the nil f.openedOnce init path it's named for. - forwarder_test.go: register StopForward cleanup for the two Forward tests so their goroutines and listeners don't leak past the test. - Trim comments in config.go/browseronopen.go that only restated the code below them.
Rewrote comments in config.go, browseronopen_test.go, and credentials_server.go to use plain sentences instead of em-dash clauses, and trimmed remaining restating text.
✅ Deploy Preview for devsydev canceled.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
Reorders openedRecorder methods so unexported record() follows the exported Len(), extracts repeated test literals into constants, and rewraps lines golines flagged as too long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary