fix(workspace): forward gpg on browser open - #904
Merged
Conversation
Signed-off-by: GitHub <noreply@github.com>
✅ Deploy Preview for devsydev canceled.
|
📝 WalkthroughWalkthroughThe PR derives IDE GPG agent forwarding from CLI or context settings, adds unit and browser IDE end-to-end coverage, and narrows automatic workflow approval while changing the GitHub App token input. ChangesGPG agent forwarding
Workflow approval configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant E2ETest
participant BrowserIDE
participant Tunnel
participant GPGAgent
E2ETest->>BrowserIDE: launch with context GPG option
BrowserIDE->>Tunnel: start forwarding tunnel
Tunnel->>GPGAgent: forward secret key
BrowserIDE-->>E2ETest: report forwarding and tunnel logs
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
Signed-off-by: GitHub <noreply@github.com>
skevetter
marked this pull request as ready for review
August 8, 2026 00:54
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/workflow-approval.yml:
- Line 22: Remove the missing pre-commit.yml entry from the workflows allowlist
in the workflow-approval configuration, leaving only the tracked workflow
references including pr-ci.yml.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b5c730d6-0bbb-4f9c-845f-c5685686b820
📒 Files selected for processing (4)
.github/workflows/workflow-approval.ymlcmd/workspace/up/configure.gocmd/workspace/up/configure_test.goe2e/tests/ide/browser_returns.go
| with: | ||
| token: ${{ steps.app-token.outputs.token }} | ||
| workflows: "commit.yml,lint.yml,pr-ci.yml,pre-commit.yml,release-please.yml,promote-release.yml" | ||
| workflows: "commit.yml,pr-ci.yml,pre-commit.yml" |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
for workflow in commit.yml pr-ci.yml pre-commit.yml; do
test -f ".github/workflows/$workflow" || {
echo "Missing .github/workflows/$workflow"
exit 1
}
doneRepository: devsy-org/devsy
Length of output: 194
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
echo "Workflow file list containing pre-commit or pr-ci:"
git ls-files '.github/workflows/*' | rg '(^|/)(pre-commit|pr-ci)\.ya?ml$' || true
echo
echo "workflow-approval.yml (line 22 area):"
sed -n '1,45p' .github/workflows/workflow-approval.yml 2>/dev/null || true
echo
echo "References to pre-commit jobs/workflows in pr-ci.yml:"
if [ -f .github/workflows/pr-ci.yml ]; then
nl -ba .github/workflows/pr-ci.yml | sed -n '1,220p'
else
echo "no .github/workflows/pr-ci.yml"
fiRepository: devsy-org/devsy
Length of output: 1060
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
echo "Existing workflow files:"
git ls-files '.github/workflows/*' | sed -n '1,120p'
echo
echo ".github/workflows/pr-ci.yml:"
awk '{printf "%6d %s\n", NR, $0}' .github/workflows/pr-ci.yml | sed -n '1,220p'
echo
echo "Search for pre-commit references:"
rg -n "pre-commit|pre_commit|pr-ci|commit\.yml" .github/workflows -S || trueRepository: devsy-org/devsy
Length of output: 9681
Remove the missing pre-commit.yml workflow reference.
.github/workflows/pre-commit.yml is not tracked, while the pre-commit task is already a job in .github/workflows/pr-ci.yml. Keeping this allowlisted path can make automatic-approve fail and leave PR runs unapproved.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/workflow-approval.yml at line 22, Remove the missing
pre-commit.yml entry from the workflows allowlist in the workflow-approval
configuration, leaving only the tracked workflow references including pr-ci.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: GitHub noreply@github.com
Summary by CodeRabbit
Bug Fixes
Workflow Updates
Tests