fix: scrollable feedback view panel for long content - #12
Merged
Conversation
GitHub secret scanning replaced the token value with '******' but did
not close the backtick template literal, causing a JS syntax error that
silently swallowed the entire headers object and made all feedback
submissions fail.
Restore the correct header: `token ${_tk}`
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The public 'what was it like working with Devyani' field (pub.t) was never written to the inbox issue. Add a '💬 Public feedback' section so all feedback is captured in one place. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 02919104-34f1-44e8-91db-7bfd688b1b6e
Mark the first teal/red/purple dots as submitted with data from the golden-seeds-inbox issues so they appear as planted on page load. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 02919104-34f1-44e8-91db-7bfd688b1b6e
Instead of hardcoding submitted dots, fetch the golden-seeds-inbox issues on every page load and hydrate the dot field in-place. This means any new submission automatically appears for all visitors without needing a code change. - submittedDots starts empty; loadSubmittedDots() fills it async - Dots render immediately (blank), then light up after the fetch - Issues are assigned to dots in creation order, per color/relationship - Anonymous and [Test] issues are skipped Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 02919104-34f1-44e8-91db-7bfd688b1b6e
…-persistence Fix dot submissions: restore auth, add public feedback, auto-populate from inbox
Early submissions (before today's fix) have no public feedback text. Show 'No public feedback shared yet.' instead of empty curly quotes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 02919104-34f1-44e8-91db-7bfd688b1b6e
…n-persistence fix: show placeholder when public feedback text is empty
Remove el.disabled=true/false from dot buttons — CSS pointer-events:none on the color class already blocks unsubmitted dots; setting disabled on a <button> blocks platform-level mouse events even after re-enabling, which is why loadSubmittedDots-hydrated dots were non-interactive. Unsubmitted dots now rely purely on CSS pointer-events:none + tabIndex=-1. Submitted dots (via form submission or loadSubmittedDots) get dot--submitted class which applies pointer-events:auto via the existing CSS rules. Also closed inbox issues #3 (Rachel), #4 (old April), #5 (Ricky) so only April's latest submission (#6, with public feedback) shows as a dot. Co-authored-by: Devyani Jain <devyanijain0@gmail.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 02919104-34f1-44e8-91db-7bfd688b1b6e
Remove bottom:auto and min-height overrides on #viewVariant. It now matches editVariant layout (flex column, full height), so contentBar's overflow-y:auto kicks in for long feedback text. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 02919104-34f1-44e8-91db-7bfd688b1b6e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the view variant fill the panel height so long feedback text scrolls instead of overflowing. Matches the edit variant layout.