Icon back to original CodeDeck size + last Node 20 action bumps - #5
Merged
Conversation
…aming The `tauri icon` run that produced the +-badged icons shrank the mark: it generated the Android mipmaps from the loose source (mark at ~74% W / 84% H of the frame) and then added its own ~12% inset, so the launcher icons came out at ~63-71% fill vs the original CodeDeck icons' ~75-85%. Regenerate every icon (the four `bundle.icon` PNGs and all 15 mipmaps) directly from the +-badged master at the original ~74% W / 84% H framing, bypassing `tauri icon`'s inset. `ic_launcher_round.png` is a byte copy of `ic_launcher.png` per the original convention (and the manifest uses only `android:icon`). Side by side, the new icon now matches the original's size exactly — only the `+` in the top ring's inner dot differs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The v0.11.0 run still logged the deprecation warning for three actions whose v5 line (or v2, for gh-release) is still Node 20 internally: - actions/upload-artifact v5 -> v7 - actions/download-artifact v5 -> v8 - softprops/action-gh-release v2 -> v3 Usage is unchanged (name/path/if-no-files-found; tag_name/files/body/etc.), all stable across these majors. Exercised on the next release run. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes, one PR.
1. Launcher icon was smaller than the original CodeDeck icons
The
tauri iconrun in #3 generated the Android mipmaps from the loose source (mark at ~74% W / 84% H of the frame) and then added its own ~12% inset, so the launcher icons came out at ~63–71% fill vs the original CodeDeck icons' ~75–85%. Visibly smaller on the home screen.Fix: regenerate every icon (the four
bundle.iconPNGs + all 15 mipmaps) directly from the+-badged master at the original ~74% W / 84% H framing, bypassingtauri icon's inset.ic_launcher_round.pngis a byte copy ofic_launcher.png(original convention; the manifest uses onlyandroid:icon).Side by side (left = original CodeDeck, right = new): identical size now, only the
+in the top ring's inner dot differs.Fill ratio, xxxhdpi
ic_launcher.png:2. Last three Node 20 action warnings
v0.11.0's run still warned on three actions whose current pinned major is Node 20 internally:actions/upload-artifactv5 → v7actions/download-artifactv5 → v8softprops/action-gh-releasev2 → v3Usage unchanged; stable across these majors. Only
release.ymluses them, so it's exercised on the next release run (CI here just confirms the icon swap builds).Verification
release.ymlaction bumps: next release run.Ships in the next release.