fix: RaincloudSizeComparisonIntegrationTest.corpusIsHydrated skips instead of failing#272
Merged
Merged
Conversation
…stead of failing Used assertTrue (hard fail) instead of assumeTrue (visible skip) when the corpus isn't hydrated, contradicting its own class javadoc and the established pattern in RaincloudConformanceIntegrationTest.corpusIsHydrated. Broke ubuntu/macos CI on every run since the corpus isn't hydrated there. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
corpusIsHydrated()usedassertTrue(hard fail) instead ofassumeTrue(visible skip) when the Raincloud corpus isn't hydrated locally — contradicting its own class javadoc ("Skipped (visibly) when the corpus is not hydrated") and the established pattern already used byRaincloudConformanceIntegrationTest.corpusIsHydrated.build (ubuntu-latest, *)andbuild (macos-latest, *)on everymainCI run since it was introduced in 8b4e0f7, since neither runner has the corpus hydrated.Test plan
./mvnw compile test-compile -pl integration -am— compiles clean, 0 checkstyle violations🤖 Generated with Claude Code