Repository navigation
refactor: typed ScalarValue in encoder stats (#531) - #536
Merged
Merged
Conversation
dfa1
force-pushed
the
refactor/531-typed-stats
branch
from
October 16, 2026 19:42
bf4d2e2 to
e628b48
Compare
EncodeResult, CascadeStep, SegmentStats and the min/max helpers now hold ProtoScalarValue; a MinMax record replaces the two-element stats array and the zone-map sum stat is typed too. Serialization happens once at the FlatBuffer boundary (VortexWriter#buildArrayFlatBuffer) and zone-map pruning reads the typed value directly. No wire change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dfa1
force-pushed
the
refactor/531-typed-stats
branch
from
October 16, 2026 19:46
e628b48 to
8377226
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #531.
EncodeResult,CascadeStep,SegmentStats, and the min/max helpers (PrimitiveEncodingEncoder,ZoneMapStats,VarBinEncodingEncoder,ZoneMapStatCodec) carryProtoScalarValueinstead of serializedbyte[]. Bytes are produced once, inbuildArrayFlatBuffer. The array-recordS6218suppressions on the two carriers are gone. Sums staybyte[].No wire change.
./mvnw test -pl writer -amand./mvnw verify -pl integration -ampass. No CHANGELOG entry (internal refactor).🤖 Generated with Claude Code