Fix pre-commit findings: mypy no-any-return, pylint warnings, missing EOF newline - #1400
Open
spoorcc wants to merge 1 commit into
Open
Fix pre-commit findings: mypy no-any-return, pylint warnings, missing EOF newline#1400spoorcc wants to merge 1 commit into
spoorcc wants to merge 1 commit into
Conversation
… EOF newline - Wrap Prompt.ask().strip() calls in str() to satisfy mypy's no-any-return check in dfetch/terminal/prompt.py and dfetch/commands/add.py. - Rename unused `context` step argument to `_context` in features/steps/git_steps.py to fix pylint's unused-argument warning. - Rename the module-level `keystrokes` variable in doc/generate-casts/interactive_helper.py to avoid pylint's redefined-outer-name warning against the same-named local variables. - Add missing trailing newline to security/dfetch.component-definition.json. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017w9xdxabPZ98pNJfbm9Dmd
Contributor
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check in dfetch/terminal/prompt.py and dfetch/commands/add.py.
contextstep argument to_contextinfeatures/steps/git_steps.py to fix pylint's unused-argument warning.
keystrokesvariable indoc/generate-casts/interactive_helper.py to avoid pylint's
redefined-outer-name warning against the same-named local variables.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_017w9xdxabPZ98pNJfbm9Dmd