Skip to content

Fix pre-commit findings: mypy no-any-return, pylint warnings, missing EOF newline - #1400

Open
spoorcc wants to merge 1 commit into
mainfrom
claude/pre-commit-fixes-uf8li1
Open

Fix pre-commit findings: mypy no-any-return, pylint warnings, missing EOF newline#1400
spoorcc wants to merge 1 commit into
mainfrom
claude/pre-commit-fixes-uf8li1

Conversation

@spoorcc

@spoorcc spoorcc commented Aug 28, 2026

Copy link
Copy Markdown
Contributor
  • Wrap Prompt.ask().strip() calls in str() to satisfy mypy's no-any-return
    check in dfetch/terminal/prompt.py and dfetch/commands/add.py.
  • Rename unused context step argument to _context in
    features/steps/git_steps.py to fix pylint's unused-argument warning.
  • Rename the module-level keystrokes variable in
    doc/generate-casts/interactive_helper.py to avoid pylint's
    redefined-outer-name warning against the same-named local variables.
  • Add missing trailing newline to security/dfetch.component-definition.json.

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_017w9xdxabPZ98pNJfbm9Dmd

… EOF newline

- Wrap Prompt.ask().strip() calls in str() to satisfy mypy's no-any-return
  check in dfetch/terminal/prompt.py and dfetch/commands/add.py.
- Rename unused `context` step argument to `_context` in
  features/steps/git_steps.py to fix pylint's unused-argument warning.
- Rename the module-level `keystrokes` variable in
  doc/generate-casts/interactive_helper.py to avoid pylint's
  redefined-outer-name warning against the same-named local variables.
- Add missing trailing newline to security/dfetch.component-definition.json.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017w9xdxabPZ98pNJfbm9Dmd
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 42 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 584b52bb-ae08-4c11-bbeb-8f38024af11c

📥 Commits

Reviewing files that changed from the base of the PR and between edc169d and 3fb3c6a.

📒 Files selected for processing (5)
  • dfetch/commands/add.py
  • dfetch/terminal/prompt.py
  • doc/generate-casts/interactive_helper.py
  • features/steps/git_steps.py
  • security/dfetch.component-definition.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants