Conversation
This drops base64 0.13.1 (released 4 years ago) and consolidates our the base64 versions around 0.22.1. This includes some API changes (mostly specifying the decoding options via eg `base64::prelude::BASE64_STANDARD::decode(...)` & friends) and drops the `openssh-keys` (does not support recent base64, so we inline the `ssh-rsa`-specific decoding).
|
✅ No security or compliance issues detected. Reviewed everything up to 2ef666a. Security Overview
Detected Code Changes
|
|
✅ No security or compliance issues detected. Reviewed everything up to 2ef666a. Security Overview
Detected Code Changes
|
|
✅ No security or compliance issues detected. Reviewed everything up to 2ef666a. Security Overview
Detected Code Changes
|
|
✅ No security or compliance issues detected. Reviewed everything up to 2ef666a. Security Overview
Detected Code Changes
|
|
✅ No security or compliance issues detected. Reviewed everything up to 2ef666a. Security Overview
Detected Code Changes
|
|
Non-blocking note from the governance side (no action needed, just so the consequence is on record). The That touches two governance validators:
The logo one sits on an upgrade path: I checked mainnet before approving: of the 54 entries from If you'd prefer to keep 0.13 semantics exactly at these two call sites, a local engine with |
…api_tests.rs Co-authored-by: Pierugo Pace <pierugo.pace@dfinity.org>
…STANDARD Address review feedback: pad the base64-encoded Ed25519 DER public key test constants instead of decoding with BASE64_STANDARD_NO_PAD. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016kWotpWN6DJC8SWj5qriBK
|
The Update: a second job in the same run, I've queued a re-run of both affected jobs ( Generated by Claude Code |
This drops base64 0.13.1 (released 4 years ago) and consolidates the base64 versions around 0.22.1.
This includes some API changes (mostly specifying the decoding options via eg
base64::prelude::BASE64_STANDARD::decode(...)& friends) and drops theopenssh-keys(does not support recent base64, so we inline thessh-rsa-specific decoding).