[kaskader201]

spacing.anonymousFunction: the space after the function of a closure

spacing.keyword covers every keyword, including the function of a closure, and it only takes 'return $x' or keep. So a project that writes its closures as function($x) can't require the PSR-12 space after if, foreach, catch, match and } else {. Its only choice is keep, and with keep nothing checks keyword spacing at all.

The closure is the only one of its siblings without its own decision:

• spacing.arrowFunction covers the arrow function ('fn($x) => $x' / 'fn ($x) => $x').
• spacing.anonymousClass covers the anonymous class ('new class($a)' / 'new class ($a)').
• PHP CS Fixer has the same split: function_declaration takes closure_function_spacing beside closure_fn_spacing. Before this PR, closure_fn_spacing already mapped to spacing.arrowFunction, but closure_function_spacing: none mapped to nothing and only produced a warning.

What changes

• New decision spacing.anonymousFunction: 'function($x)', 'function ($x)' or keep. It is declared and enforced by ConstructSpacingRule, next to spacing.arrowFunction.
• Name. anonymousFunction is the word for this place in the closed list of places in docs/internals.md. types.declaration.anonymousFunction already uses it.
• Scope. The decision rules on the gap after the function of a closure, whatever follows it. That covers function (, static function ( and a closure returning by reference, which becomes function &( or function&( (this matches what closure_function_spacing does). The function of a declaration and the use of a closure stay under spacing.keyword.
• keep leaves the closure alone. It does not fall back to spacing.keyword, which is how spacing.arrowFunction behaves.
• The standards. PSR-12 sets 'function ($x)'. PER CS, Nette, Symfony (function_declaration with its default closure_function_spacing: one) and Laravel Pint inherit it. None of the standards changes what it enforces: the reference shows 'function ($x)' for all five.
• Interop:
  • PHP CS Fixer function_declaration: closure_function_spacing maps to spacing.anonymousFunction, and spacing.keyword: spaced is now set for both of its values. The warning for none is gone.
  • PHP_CodeSniffer Squiz.Functions.MultiLineFunctionDeclaration: the PEAR sniff it extends requires one space after the function of a closure (SpaceAfterFunction), so it maps to 'function ($x)'.

Note on existing configurations

Before this PR, a configuration that set spacing.keyword: 'return $x' without a standard preset also spaced its closures. With this PR, it has to add spacing.anonymousFunction: 'function ($x)' to keep that behaviour, because the new decision defaults to keep like spacing.arrowFunction does. Configurations built on a standard preset, or translated from PHP CS Fixer or PHP_CodeSniffer, are not affected. If you would rather keep the old behaviour for such configurations, the alternative is to have keep fall back to spacing.keyword, but then the two siblings would behave differently.

Tests

• New fixtures in constructSpacing:
  • both values on a plain, a static and a by-reference closure with use (…)
  • 'function($x)' together with spacing.keyword, where if( and return $x are fixed and function foo follows the keyword decision
  • keep
  • a closure inside an arrow function and the other way round, each following its own decision
• Translator.phpt covers closure_function_spacing: none and the default.
• composer reference was regenerated. composer api produced no change.
• composer tester, composer phpstan and bin/dresscode check give the same results as on master:
  • the same 3 failing tests: forbiddenPhpdocLines, a Translator.phpt case that needs simplexml (missing from my local PHP), and the import case in Application.phpt
  • the same 4 PHPStan errors
  • check is clean

🤖 Generated with Claude Code

[dg]

Thank you! Merged into master. On top of it I made the ampersand of a closure or an arrow function returning a reference hug its parenthesis, function &($x) and fn&($x), so that function& ($x) no longer ends up as function & ($x).